On Tue, Jan 13, 2004 at 05:32:28PM +0100, Roland Gersch wrote:
Hamish Moffatt wrote:
On Tue, Jan 13, 2004 at 12:23:23PM +0200, Markus Peuhkuri wrote:The lines above - together with their #ifndef DVB_TDA1004X_FIRMWARE_FILE (...)
):
-#define DVB_TDA1004X_FIRMWARE_FILE "/etc/dvb/tda1004x.mc"
+#define DVB_TDA1004X_FIRMWARE_FILE "/usr/lib/hotplug/firmware/tda1004x.mc"
The kernel configuration lets you set the path, but it seems to be ignored. I didn't check the code, I'm only observing based on the fact that I set it to /etc in the config and the kernel still used /usr/lib.
#endif context - look OK to me. Can you check whether there actually is a DVB_TDA...
definition in your .config?
Yes there is, set to /etc/dvb/tda1004x.bin.
How does the config option get translated to a DVB_TDA1004X_FIRMWARE_FILE define? There's nothing in the Makefile which would seem to cause it to be passed in on the compiler command line.
There's a linux/include/config/dvb/tda1004x/firmware/file.h, and that seems to get pulled into <linux/config.h>, which tda1004x.c doesn't use. Looks like that would fix it.
I didn't investigate further into file.h, but maybe the following patch fixes the problem:
--- drivers/media/dvb/frontends/tda1004x.c 2004-01-10 13:57:47.000000000
+0100
+++ drivers/media/dvb/frontends/tda1004x.c 2004-01-16 07:49:39.000000000 +0100
@@ -41,11 +41,14 @@
#include <linux/unistd.h>
#include <linux/fcntl.h>
#include <linux/errno.h>
+#include <linux/config.h>
#include "dvb_frontend.h"
#include "dvb_functions.h"
-#ifndef DVB_TDA1004X_FIRMWARE_FILE +#ifndef CONFIG_DVB_TDA1004X_FIRMWARE_FILE #define DVB_TDA1004X_FIRMWARE_FILE "/usr/lib/hotplug/firmware/tda1004x.mc" +#else +#define DVB_TDA1004X_FIRMWARE_FILE CONFIG_DVB_TDA1004X_FIRMWARE_FILE #endif
static int tda1004x_debug = 0;
-- Info: To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe linux-dvb" as subject.
