> NOTE: This patch appears to have uncovered a bug in DxeCore's > AllocatePages routine. If the first > allocate_pages(EFI_ALLOCATE_ADDRESS) call fails, we may still end up > with a memory map that reflects a kind of limbo state where the intended > allocation is carved out and partially converted.
Nice find! > > That feels a little bit eeew, but I can't see it breaking anything. > > Yes, it does. But the alternative (assuming EfiLoaderData allocations in the > region are safe) is worse, so I guess we will have to live with it. The loader allocating boot service data regions is harmless enough since BS regions will effectively be owned by the OS/loader after ExitBootServices anyways. Reviewed-by: Eugene Cohen <[email protected]>
