Hi Jianan,

On Sat, Nov 13, 2021 at 12:09:33AM +0800, Huang Jianan wrote:
> From: Huang Jianan <[email protected]>
> 
> Renaming lz4_0padding to zero_padding globally since LZMA and later
> algorithms also need that.
> 
> Signed-off-by: Huang Jianan <[email protected]>

I'm fine with renaming the original on-disk feature from lz4_0padding
to zero_padding... but could we leave `support_0padding' as-is?

My own concern is
 1) it seems 'support_zero_padding' is not much better than
    'support_0padding' but it causes somewhat longer lines...

 2) it causes somewhat backporting overhead but with no real
    benefits...

Otherwise it looks good to me. If you agree on this, I could
update this patch manually at the time when I apply this (maybe
about this weekend).

Thanks,
Gao Xiang

Reply via email to