在 2021年11月16日星期二，Gao Xiang <[email protected]> 写道：
> Hi Jianan, > > On Sat, Nov 13, 2021 at 12:09:33AM +0800, Huang Jianan wrote: > > From: Huang Jianan <[email protected]> > > > > Renaming lz4_0padding to zero_padding globally since LZMA and later > > algorithms also need that. > > > > Signed-off-by: Huang Jianan <[email protected]> > > I'm fine with renaming the original on-disk feature from lz4_0padding > to zero_padding... but could we leave `support_0padding' as-is? > > My own concern is > 1) it seems 'support_zero_padding' is not much better than > 'support_0padding' but it causes somewhat longer lines... > > 2) it causes somewhat backporting overhead but with no real > benefits... > > Otherwise it looks good to me. If you agree on this, I could > update this patch manually at the time when I apply this (maybe > about this weekend). > > Hi Xiang, I modified this because considering that it starts with a number, there may be problems with future expansion. This may be overly worrying because we won’t use it as a prefix of variable name. So be free to use 'support_0padding'. Thanks, Jianan > Thanks, > Gao Xiang > >
