On 2018/7/24 17:27, Yunlong Song wrote: > Without this patch, f2fs only clears victim_secmap when it finds out > that the section has no valid blocks at all, but forgets to clear the > victim_secmap when the whole section has full valid blocks.
Look this patch again, I have a question, why bggc selected section can get back to full state? Thanks, > > Signed-off-by: Yunlong Song <yunlong.s...@huawei.com> > --- > fs/f2fs/segment.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index cfff7cf..0a79554 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -776,7 +776,8 @@ static void __remove_dirty_segment(struct f2fs_sb_info > *sbi, unsigned int segno, > if (test_and_clear_bit(segno, dirty_i->dirty_segmap[t])) > dirty_i->nr_dirty[t]--; > > - if (get_valid_blocks(sbi, segno, true) == 0) > + if (get_valid_blocks(sbi, segno, true) == 0 || > + get_valid_blocks(sbi, segno, true) == BLKS_PER_SEC(sbi)) > clear_bit(GET_SEC_FROM_SEG(sbi, segno), > dirty_i->victim_secmap); > } > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel