On 06/19, Joe Perches wrote: > On Wed, 2019-06-19 at 11:01 -0700, Jaegeuk Kim wrote: > > On 06/18, Chao Yu wrote: > > > From: Joe Perches <[email protected]> > > > > > > - Add and use f2fs_<level> macros > > > - Convert f2fs_msg to f2fs_printk > > > - Remove level from f2fs_printk and embed the level in the format > > > - Coalesce formats and align multi-line arguments > > > - Remove unnecessary duplicate extern f2fs_msg f2fs.h > > > > Can we just use sbi for f2fs_<level>? > > Not really. see below:
Since sbi = F2FS_SB(sb), I don't see any problem. > > > And, could you please change missing > > f2fs_msg() in the latest dev? > > Anyone is welcome to refresh the patch as necessary > or appropriate. Could you please take a look at this? https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=697743b1c1025483c97c740cd8834711be4294eb Thanks, > > > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c > [] > > > @@ -261,35 +264,29 @@ static int f2fs_set_qf_name(struct super_block *sb, > > > int qtype, > > > int ret = -EINVAL; > > > > > > if (sb_any_quota_loaded(sb) && !F2FS_OPTION(sbi).s_qf_names[qtype]) { > > > - f2fs_msg(sb, KERN_ERR, > > > - "Cannot change journaled " > > > - "quota options when quota turned on"); > > > + f2fs_err(sb, "Cannot change journaled quota options when quota > > > turned on"); > > > return -EINVAL; > > > } > > > if (f2fs_sb_has_quota_ino(sbi)) { > > > - f2fs_msg(sb, KERN_INFO, > > > - "QUOTA feature is enabled, so ignore qf_name"); > > > + f2fs_info(sb, "QUOTA feature is enabled, so ignore qf_name"); > > > return 0; > > > } > > etc... > _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
