On Thu, 2019-06-20 at 10:08 +0800, Chao Yu wrote: > On 2019/6/20 4:52, Jaegeuk Kim wrote: > > On 06/19, Joe Perches wrote: > > > On Wed, 2019-06-19 at 11:01 -0700, Jaegeuk Kim wrote: > > > > On 06/18, Chao Yu wrote: > > > > > From: Joe Perches <[email protected]> > > > > > > > > > > - Add and use f2fs_<level> macros > > > > > - Convert f2fs_msg to f2fs_printk > > > > > - Remove level from f2fs_printk and embed the level in the format > > > > > - Coalesce formats and align multi-line arguments > > > > > - Remove unnecessary duplicate extern f2fs_msg f2fs.h > > > > > > > > Can we just use sbi for f2fs_<level>? > > > > > > Not really. see below: > > > > Since sbi = F2FS_SB(sb), I don't see any problem. > > > > > > And, could you please change missing > > > > f2fs_msg() in the latest dev? > > > > > > Anyone is welcome to refresh the patch as necessary > > > or appropriate. > > > > Could you please take a look at this? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=697743b1c1025483c97c740cd8834711be4294eb > > Looks good to me.
Me too. cheers, Joe _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
