Hi Ju Hyung,
On 2019/8/14 17:22, Ju Hyung Park wrote:
> Hi Chao,
>
> You're right and Android will never use those types.
>
> But then again, what's the point of separating the list?
I'm just thinking to use extension list space more efficiently to avoid free
slot exhaustion.
And in android, let f2fs_create() always to compare nonexistent extension name
is unneeded, right?
> I haven't encountered an Android user or an OEM that wants to
> customize this list by passing an argument to mkfs.f2fs.
That sounds sad for this interface's low use frequency, except Google and
Huawei, it looks f2fs needs more stable users first, now vendor like Huawei,
just use default list (had upstreamed .db as hot type as default yet). :(
>
> If an OEM want to customize this list, directly modifying the code for
> mkfs.f2fs sounds better anyways.
Yes, also we support adding/deleting extensions via sys node.
Thanks,
>
> Thanks.
>
> On Wed, Aug 14, 2019 at 10:51 AM Chao Yu <yuch...@huawei.com> wrote:
>>
>> On 2019/8/13 6:52, Park Ju Hyung wrote:
>>> Similar to .db files, these are randomly updated extremely frequently.
>>
>> It looks android doesn't need this, how about adding them under "#ifndef
>> WITH_ANDROID"?
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Park Ju Hyung <qkrwngud...@gmail.com>
>>> ---
>>> mkfs/f2fs_format.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
>>> index 37d82c3..1c08e3e 100644
>>> --- a/mkfs/f2fs_format.c
>>> +++ b/mkfs/f2fs_format.c
>>> @@ -94,6 +94,11 @@ const char *media_ext_lists[] = {
>>>
>>> const char *hot_ext_lists[] = {
>>> "db",
>>> +
>>> + /* Virtual machines */
>>> + "vmdk", // VMware or VirtualBox
>>> + "vdi", // VirtualBox
>>> + "qcow2", // QEMU
>>> NULL
>>> };
>>>
>>>
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
