On 5/12/26 14:35, Christoph Hellwig wrote:
> Only the file operation method knows what block device we'll swap
> to.  So move down setting sis->bdev and the special blockdev flag
> into ->swap_activate.
> 
> Signed-off-by: Christoph Hellwig <[email protected]>

One nit below. Otherwise, looks OK to me.

Reviewed-by: Damien Le Moal <[email protected]>

> @@ -141,7 +141,6 @@ int generic_swap_activate(struct file *swap_file, struct 
> swap_info_struct *sis)
>               continue;
>       }
>       return 0;
> -

whiteline change.

>  bad_bmap:
>       pr_err("swapon: swapfile has holes\n");
>       return -EINVAL;
-- 
Damien Le Moal
Western Digital Research


_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to