On 5/13/26 14:58, Christoph Hellwig wrote: > On Tue, May 12, 2026 at 10:08:46AM -0700, Darrick J. Wong wrote: >>> + /* Only one bdev per swap file for now. */ >>> + if (!sis->bdev) >>> + sis->bdev = bdev; >>> + else if (bdev != sis->bdev) >>> + return -EINVAL; >> >> Should this return error if the bdev is zoned? AFAICT XFS and zonefs >> already guard against this, but other fses might be more naïve. > > Yes, now that the bdev is passed down to add_swap_extent we could > consolidate the check here.
Hmmm... With zonefs, swap files can be created on top of conventional zone files. So enforcing "no swap on zoned device" here would break that. -- Damien Le Moal Western Digital Research _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
