>>>>> " " == Alexander Viro <[EMAIL PROTECTED]> writes:

     > On Fri, 22 Jun 2001, Anton Altaparmakov wrote:

    >> Just as a matter of interest: why do you define NFS_I as a
    >> static inline function while you leave NFS_FS as a preprocessor
    >> macro? I assume there is some good reason I am missing to do
    >> this... (could it be side effects?)

     > Basically, laziness. It would be a bit cleaner as inline, but
     > unlike NFS_I() it was already there, so it was left as it was,
     > aside of the effect of global replacement (inode->u.nfs_i.foo
     > to NFS_I(inode)->foo).

Originally, the code was littered with constructs of the type

 NFS_FH(inode) = blah;

I think we're rid of them now, so there should be nothing wrong with
making NFS_FH() an inline. I'm thinking of doing a full cleanup of
those defines in nfs_fs.h but not right now in the middle of my thesis
writeup...

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]

Reply via email to