On Fri, Nov 29, 2013 at 6:21 PM, Bruno Randolf <[email protected]> wrote:
> [Me]

>> ISA-style probing, yeah I had to accept this last time ...
>> So no discovery on this system, no ACPI?
>
> The system has ACPI, but GPIOs were not working... I don't know enough
> about ACPI, but if someone tells me what to look for I can try to debug it.

Yeah :-/

I don't know how you do the driver/board split in x86 so
please enlighten me.

>> Please devm_kzalloc() a state container
>> instead, look in other GPIO drivers for examples of this.
>
> Do you have a good example?

Most new drivers ..
gpio-intel-mid.c
gpio-tb10x.c
gpio-em.c

>> So if you really only support push/pull, open drain and maybe even
>> open source, then it's OK to use the GPIO subsystem. If you start
>> doing more things, this becomes a matter of pin control.
>
> It can just be configured as just push/pull or open drain. Is there any
> way this can be configured within the GPIO subsystem?

Yeah that's OK. grep for GPIOF_OPEN_DRAIN,
GPIOF_OPEN_SOURCE.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to