Hi Sergei, Thank you for the patch.
On Friday 26 June 2015 01:40:56 Sergei Shtylyov wrote: > The PFC driver causes the kernel to hang on the R-Car gen2 SoC based boards > when the CPU_ALL_PORT() macro is fixed to reflect the reality, i.e. when > the GPIO space becomes actually sparse. This happens because the > _GP_GPIO() macro includes an indexed initializer which causes the "holes" > (array entries filled with all 0s) between the groups of the existing > GPIOs; and the driver can't cope with that. There seems to be no reason > to use the indexed initializer, so we can remove the index specifier and so > avoid the "holes". > > Signed-off-by: Sergei Shtylyov <[email protected]> I initially thought that this patch looked too good to be true. The fix is so simple, there must have been a reason why _GP_GPIO used indexed initializers. I then tried to find that reason and failed. I still feel that this is too simple to be true, but I have no objective reason to push back, so Acked-by: Laurent Pinchart <[email protected]> for the whole series, provided you have tested it, and paid attention to pins after the holes. > --- > Changes in version 3: > - new patch. > > drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pinctrl/drivers/pinctrl/sh-pfc/sh_pfc.h > =================================================================== > --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ linux-pinctrl/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -224,7 +224,7 @@ struct sh_pfc_soc_info { > > /* PINMUX_GPIO_GP_ALL - Expand to a list of sh_pfc_pin entries */ > #define _GP_GPIO(bank, _pin, _name, sfx) \ > - [(bank * 32) + _pin] = { \ > + { \ > .pin = (bank * 32) + _pin, \ > .name = __stringify(_name), \ > .enum_id = _name##_DATA, \ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
