On Tue, Jul 7, 2015 at 7:39 PM, Laurent Pinchart <[email protected]> wrote: > On Friday 26 June 2015 01:40:56 Sergei Shtylyov wrote: >> The PFC driver causes the kernel to hang on the R-Car gen2 SoC based boards >> when the CPU_ALL_PORT() macro is fixed to reflect the reality, i.e. when >> the GPIO space becomes actually sparse. This happens because the >> _GP_GPIO() macro includes an indexed initializer which causes the "holes" >> (array entries filled with all 0s) between the groups of the existing >> GPIOs; and the driver can't cope with that. There seems to be no reason >> to use the indexed initializer, so we can remove the index specifier and so >> avoid the "holes". >> >> Signed-off-by: Sergei Shtylyov <[email protected]> > > I initially thought that this patch looked too good to be true. The fix is so > simple, there must have been a reason why _GP_GPIO used indexed initializers. > I then tried to find that reason and failed. > > I still feel that this is too simple to be true, but I have no objective > reason to push back, so
:-) > Acked-by: Laurent Pinchart <[email protected]> > > for the whole series, provided you have tested it, and paid attention to pins > after the holes. On r8a7791/koelsch, the switches (gpio banks 5 and 7) and LEDs (gpio bank 2) still work, so Tested-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
