On 11/12/05, David Lee <[EMAIL PROTECTED]> wrote: > On Sat, 12 Nov 2005, Xun Sun wrote: > > > Hi David, > > > > In this commit you defined ocf_is_hexadecimal in ocf-shellfuncs.in, > > but used ocf_is_hex in other places, which looks inconsistent to me. > > Unfortunately you seem unaware of this problem even though I mentioned > > it in my last two mails ;-) > > > > So I have just committed a one-liner fix for this. Feel free to change > > to other appropriate things. > > Yes. My mistake entirely, for which my apologies. Thanks for fixing it. > > I also saw your other point about my re-implementing the pattern matching > (rewriting the "case" statement into a "tr"). I'm still looking at that. > > The original "case" was failing on my Solaris "sh", hence my looking for
How did it fail, syntax error or giving wrong output (in this case it is possible that my original script is faulty) ? Could you please send me a transcript if possible? > something guaranteed to be portable. Hence that: > echo ...| tr ... > > It is portable (good) but less efficient (bad). > > Looking deeper, I think I can see a portable way to restore the "case" > implementation, which I think we would both (all on the list?) like, but I > need to check it more thoroughly. > > > -- > > : David Lee I.T. Service : > : Senior Systems Programmer Computer Centre : > : Durham University : > : http://www.dur.ac.uk/t.d.lee/ South Road : > : Durham DH1 3LE : > : Phone: +44 191 334 2752 U.K. : > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ > -- Thanks & regards Xun Sun _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
