Alan Robertson wrote:
Andrew Beekhof wrote:
On 5/11/06, [email protected]
<[email protected]> wrote:
linux-ha CVS committal
Author : lars
Host :
Project : linux-ha
Module : heartbeat
Dir : linux-ha/heartbeat
Modified Files:
heartbeat.c
Log Message:
Coverity #42: Static buffer overrun in our re-transit code!
What IS this patch? It doesn't have anything to do with it's title?
Please pull the patch. If you want to break the code, let's at least
discuss it first. In fact, we did discuss this before, and I said DO
NOT MAKE THIS CHANGE.
This will break more than you know!!!!
OK. I've calmed down now ;-)
And, I see that this was a clerical error, which you caught. And I
apologize for my email. But, it's a good idea to do a cvs diff -u
before committing - on general principles.
Thanks for catching your clerical error. I probably wouldn't have seen
it if Andrew hadn't quoted it in his email - so it's good that you
caught it.
But, before you fix things in the heartbeat protocol, it is a good idea
to run it by gshi and/or me. In this case, you exchanged a highly
improbable crash [i.e., it's never happened in 6 years AFAIK] for a
soemwhat less improbable infinite loop (one in 200 requests to
retransmit a "too old" packet will cause an infinite loop).
--
Alan Robertson <[EMAIL PROTECTED]>
"Openness is the foundation and preservative of friendship... Let me
claim from you at all times your undisguised opinions." - William
Wilberforce
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
