On 2006-05-11T07:41:54, Alan Robertson <[EMAIL PROTECTED]> wrote:
> OK. I've calmed down now ;-)
Great ;-)
> And, I see that this was a clerical error, which you caught. And I
> apologize for my email. But, it's a good idea to do a cvs diff -u
> before committing - on general principles.
I know. I forgot that I had those possible changes from way-back-when
sitting around still.
Sorry for blowing your fuse. ;-)
> But, before you fix things in the heartbeat protocol, it is a good idea
> to run it by gshi and/or me. In this case, you exchanged a highly
> improbable crash [i.e., it's never happened in 6 years AFAIK] for a
> soemwhat less improbable infinite loop (one in 200 requests to
> retransmit a "too old" packet will cause an infinite loop).
Sorry about that. It looked like a straightforward buffer-overrun fix to
me, but I seem to have missed those side effects... That's what I got
for "one last fix" before the vacation. ;-)
Sincerely,
Lars Marowsky-Brée
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
