Andrew Beekhof wrote:
On 5/9/06, linux-ha-cvs@lists.linux-ha.org <linux-ha-cvs@lists.linux-ha.org> wrote:linux-ha CVS committal Author : sunjd Host : Project : linux-ha Module : lib Dir : linux-ha/lib/plugins/lrm Modified Files: raexecocf.c Log Message: Bug 1222 fixing - a silly bugok, I know I'm nitpicking a little here but its important... this log message is crap. a buffer overrun is a *very* important thing to have fixed and the patch should be clearly identified as such in CVS. compare what you wrote to Lars' commit message for a very similar commit.
Good reminding, thanks. I'll pay attention to it.
=================================================================== RCS file: /home/cvs/linux-ha/linux-ha/lib/plugins/lrm/raexecocf.c,v retrieving revision 1.56 retrieving revision 1.57 diff -u -3 -r1.56 -r1.57 --- raexecocf.c 27 Mar 2006 15:53:10 -0000 1.56 +++ raexecocf.c 9 May 2006 09:03:16 -0000 1.57 @@ -316,7 +316,7 @@ g_str_tmp = g_string_new(""); while(!feof(file)) { memset(buff, 0, BUFF_LEN); - read_len = fread(buff, 1, BUFF_LEN, file); + read_len = fread(buff, 1, BUFF_LEN - 1, file); if (0<read_len) { g_string_append(g_str_tmp, buff); } _______________________________________________ Linux-ha-cvs mailing list Linux-ha-cvs@lists.linux-ha.org http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs_______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
-- BRs, Sun Jiang Dong _______________________________________________________ Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
