On 2006-06-16T18:28:08, Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote:
> On 2006-06-15T03:20:24, [email protected] wrote: > > > linux-ha CVS committal > > > > Author : sunjd > > Host : > > Project : linux-ha > > Module : lib > > > > Dir : linux-ha/lib/fencing > > > > > > Modified Files: > > stonithd_lib.c > > > > > > Log Message: > > tweaking logs; add more check for ipc functions > > =================================================================== > > RCS file: /home/cvs/linux-ha/linux-ha/lib/fencing/stonithd_lib.c,v > > retrieving revision 1.23 > > retrieving revision 1.24 > > diff -u -3 -r1.23 -r1.24 > > --- stonithd_lib.c 1 Jun 2006 06:22:33 -0000 1.23 > > +++ stonithd_lib.c 15 Jun 2006 09:20:23 -0000 1.24 > > @@ -820,10 +832,14 @@ > > stdlib_log(LOG_DEBUG, "%s = %s.", field_name2, tmpstr); > > rc= TRUE; > > } else { > > - stdlib_log(LOG_DEBUG, "no field %s.", field_name2); > > + stdlib_log(LOG_NOTICE, "filed <%s> content is <%s>" > > + , field_name2 > > + , (NULL == tmpstr) ? "NULL" : tmpstr); > > } > > } else { > > - stdlib_log(LOG_DEBUG, "No field %s", field_name1); > > + stdlib_log(LOG_NOTICE, "filed <%s> content is <%s>" > > + , field_name1 > > + , (NULL == tmpstr) ? "NULL" : tmpstr); > > } > > These two trigger for _every_ op performed, including "monitor". That's, > uhm, quite cluttering the logs: > > Jun 16 16:25:44 xen-4 lrmd: [3133]: notice: filed <apirpl> content is > <raopret> > > Is that really necessary? > > (Besides the log being exactly the same for both cases, I wonder whether > they should be somehow differentiated?) I see you changed this code slightly by now, but now I keep getting: Jun 19 14:38:12 xen-1 lrmd: [2564]: notice: field <reply> content is <raopret>, expected content is: <stret> every time a monitor op is invoked on a STONITH plugin. (Oh, and btw, it's still logging exactly the same error message for two error legs - is that right?) Sincerely, Lars Marowsky-Brée -- High Availability & Clustering SUSE Labs, Research and Development SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin "Ignorance more frequently begets confidence than does knowledge" _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
