In gmane.linux.highavailability.devel Keisuke MORI <[EMAIL PROTECTED]> wrote: > [-- text/plain, encoding 7bit, charset: ISO-8859-1, 40 lines --] > > Hi, > > The attachment is a patch for pgsql.in to fix an annoying > problem and some typos. > > * Problem: > > Pgsql fails to launch PostgreSQL unobviously even if it's > configured properly. > > The cause is that PostgreSQL log file /var/log/pgsql.log, which > is hard-coded in the script, is not usually writable to PGDBA > user (at least on RedHat EL4), and pgsql just returns with no > obvious log messages when it failed to create the log file, so > users will be puzzled why it failed. > > * Solution: > > This patch fixes it as follows, and also fixes some typos: > > - make the log file path configurable as an OCF parameter > "logfile" in cib.xml. > > - try to create the log file with PGDBA user and leave an error > log message if it failed. > > - default logfile path is now /dev/null. I made it so because > 1) an appropriate path largely depends on distros' or an > user's policy and 2) the default of PostgreSQL init.d script > which comes with RedHat is also /dev/null. > > > The patch is against 2.0.7. > I would appreciate if it is incorporated into the future release.
Those changes look pretty good to me. Does anyone object to committing them? -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
