Actually I don not like check_log_file function very much. It'll fail
if the log file does not exist and admin configured /var/log/pgsql.log
or so as a log file. The better approach, IMHO, would be to create a
files as root and run chown then. I'll prepare a patch later id
somebody else won't beat me.
#
# Check if we need to create a log file
#
check_log_file() {
if [ ! -w "$1" ]
then
if ! runasowner "touch $1 > /dev/null 2>&1"
then
return 1
fi
fi
return 0
}
On 8/15/06, Lars Marowsky-Bree <[EMAIL PROTECTED]> wrote:
On 2006-08-15T09:55:48, Horms <[EMAIL PROTECTED]> wrote:
> Those changes look pretty good to me.
> Does anyone object to committing them?
No, and I have done so.
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
