Hi,
this weekend I upgraded a system from Release 1.2.3 to 1.2.5 and then I
realized that the ping_group didn´t work any more. The group showed as
"dead" with cl_status, but there were echo requests and replies on the
network.
A look in the changes between the two releases gave the answer: In
Revision 1.2.4.5 of lib/plugins/HBComm/ping_group.c, line 480 is a
wrong "goto ReRead" that results in an endless loop when every hosts
answers to the ping requests. It seems like this was a mistake when
making a backport from the changes between Revision 1.18 and 1.19 for
the branch STABLE_1.2.
With the following patch, ping_group works again with Release 1.2.5:
--- lib/plugins/HBcomm/ping_group.c 2005-08-10 04:08:17.000000000 +0000
+++ lib/plugins/HBcomm/ping_group.c 2006-08-26 12:44:37.635507889 +0000
@@ -477,7 +477,7 @@
for(node = ei->node; node; node = node->next) {
if(!memcmp(&(their_addr.sin_addr), &(node->addr.sin_addr),
sizeof(struct in_addr))) {
- goto ReRead; /* Not ours */
+ break;
}
}
if(!node) {
--
Wolfgang Dumhs
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
