On 2007-01-09T13:30:33, Achim Stumpf <[EMAIL PROTECTED]> wrote:
> @@ -45,7 +45,7 @@
> : ${OCF_RESKEY_group="mysql"}
>
> : ${OCF_RESKEY_log="/var/log/mysqld.log"}
> -: ${OCF_RESKEY_pid="/var/run/mysqld/mysqld.pid"}
> +: ${OCF_RESKEY_pid="/var/lib/mysql/mysqld.pid"}
That's obviously just a changed default depending on the actual paths.
Changing the default will break it for others, for which it has likely
worked before - not good!!!
Either detect the appropriate value in configure, in the script, or
specify it explicitly.
> - $MYSQL_BINDIR/mysqld_safe --defaults-file=$OCF_RESKEY_config
> --pid-file=$OCF_RESKEY_pid --socket=$OCF_RESKEY_socket
> --datadir=$OCF_RESKEY_datadir --user=$OCF_RESKEY_user >/dev/null 2>&1 &
> + $MYSQL_BINDIR/safe_mysqld --defaults-file=$OCF_RESKEY_config
> --pid-file=$OCF_RESKEY_pid --socket=$OCF_RESKEY_socket
> --datadir=$OCF_RESKEY_datadir --user=$OCF_RESKEY_user >/dev/null 2>&1 &
> rc=$?
>
> Maybe it's better to put the mysql binary into a variable, because on
> Fedora it's called the other way around.
Yes. Please, make it configurable.
Sincerely,
Lars Marowsky-Brée
--
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge."
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
