On 3/7/07, Alan Robertson <[EMAIL PROTECTED]> wrote:
Lars Marowsky-Bree wrote:
> On 2007-03-06T20:19:54, Alan Robertson <[EMAIL PROTECTED]> wrote:
>
>> I'm currently rewriting IPaddr* and their interface to findif. Someone
>> really broke it in converting them to R2. Don't know why no one has
>> complained about them before.
>
> What's broken? Any critical issues?
The parsing of options only works if you always specify the options in a
sort of undocumented hierarchy order. In R1, this might have existed,
but it was more obvious.
And, in the process of trying but failing to fix this, the parsing in
findif was made more complicated (and incorrect).
Describing exactly what the broken code will do in various circumstances
is hard - but trust me it's broken.
A simple example:
If I specify an IP address and an interface ONLY, it won't work - even
though findif is designed to work nicely in that case.
i saw your change (a nice improvement)... would it be a good idea to
pass those values in as options (ie. -b bcast, -m mask, -n nic)?
that way its still flexible, but also usable from the command-line...
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
