David Lee wrote:
> I was just looking at bug 1576, with a view both to completing it, and
> fixing a problem the first part created for OpenBSD.
>
> I was about to abstract a small amount of code from "lib/stonith/expect.c"
> and put it, in revised form, into "clplumbing".
>
> But... I then spotted a comment at line 83:
> "This code copied from clplumbing/[...] to avoid
> making STONITH depend on clplumbing."
>
> My proposed work would introduce just such a dependency which (apparently)
> would be poor/bad.
>
> Could someone give me a little background on why such a dependency would
> be undesirable? (I'm happy to accept that it is, I'd just like to
> understand a littel more about why it is...)
First of all, the patch you put in fails on OpenBSD, and it's overkill.
It's the overkill that makes it fail on OpenBSD.
If you just prepend "exec " on the front of the command line before
executing it, it has the same results, without using that function which
isn't available everywhere (whatever it's name is - *word*).
Secondly, the plugin system is designed to be usable outside of
Heartbeat, because it's a generally useful thing regardless of the
problem you're trying to solve. And, absent a good reason, I'd like to
leave it that way.
--
Alan Robertson <[EMAIL PROTECTED]>
"Openness is the foundation and preservative of friendship... Let me
claim from you at all times your undisguised opinions." - William
Wilberforce
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
