On Tue, 17 Jul 2007, Alan Robertson wrote: > David Lee wrote: > > I was just looking at bug 1576, with a view both to completing it, and > > fixing a problem the first part created for OpenBSD. > > > > I was about to abstract a small amount of code from "lib/stonith/expect.c" > > and put it, in revised form, into "clplumbing". > > > > But... I then spotted a comment at line 83: > > "This code copied from clplumbing/[...] to avoid > > making STONITH depend on clplumbing." > > > > My proposed work would introduce just such a dependency which (apparently) > > would be poor/bad. > > > > Could someone give me a little background on why such a dependency would > > be undesirable? (I'm happy to accept that it is, I'd just like to > > understand a littel more about why it is...) > > First of all, the patch you put in fails on OpenBSD, and it's overkill. > It's the overkill that makes it fail on OpenBSD. > > If you just prepend "exec " on the front of the command line before > executing it, it has the same results, without using that function which > isn't available everywhere (whatever it's name is - *word*).
If you wish to revert that change (fe65fcbc750b) for the release, then that is probably the least damaging option. (Then the behaviour for all OSes should then the same as it was in 2.0.x . It means we still have a "known problem" on Solaris but probably that's OK for the time being.) Once 2.1.1 is safely shipped, we can try to continue progress on the bug, using a better method. > Secondly, the plugin system is designed to be usable outside of > Heartbeat, because it's a generally useful thing regardless of the > problem you're trying to solve. And, absent a good reason, I'd like to > leave it that way. Fine! Just checking that the comment in the code was still as intended. Best wishes with the release. -- : David Lee I.T. Service : : Senior Systems Programmer Computer Centre : : UNIX Team Leader Durham University : : South Road : : http://www.dur.ac.uk/t.d.lee/ Durham DH1 3LE : : Phone: +44 191 334 2752 U.K. : _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
