Hi, On Mon, Dec 03, 2007 at 05:54:54PM +0100, Andrew Beekhof wrote: > this patch would prevent the command from being used by scripts
Perhaps just to leave the long option names for -r/-w? At any rate, cibadmin should bail in case params are not valid. Thanks, Dejan > > On Dec 3, 2007, at 5:20 PM, Xinwei Hu wrote: > > >Hi all, > > > > We have a instance about cibadmin recently. A typo of 'cibadmin -r > >blahblah' forces the HA into RO mode without any warning, and the > >field engineer almost panic. ;) > > > > This leads me to think that cibadmin should give detailed warning > >on these dangerous options ahead. But the change will inevitably > >change the current behavior of cibadmin. > > > > A draft patch is attached for this purpose. Your insightful > >comments are welcome. > > > > Thanks. > >< > >cibadmin.patch>_______________________________________________________ > >Linux-HA-Dev: [email protected] > >http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > >Home Page: http://linux-ha.org/ > > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
