ah, sorry, i hadn't seen this patch when i replied earlier.
i'll apply something like this tomorrow (i might standardize the on --
force though as its used in other tools too).
On Dec 4, 2007, at 6:14 PM, Xinwei Hu wrote:
2007/12/5, Lars Marowsky-Bree <[EMAIL PROTECTED]>:
On 2007-12-04T21:29:35, Xinwei Hu <[EMAIL PROTECTED]> wrote:
The more dangerous commands usually require a --force option on
other
tools. (fsck, mkfs, rpm, drbdadm, ...)
The reason that I don't go this way is concerning the portability.
getopt_long is not a POSIX standard AFAIK.
Then make it -f or --force; that would be acceptable as well.
For cibadmin, -E, -r, (-b, -h, -l for write commands) seem safe
candidates.
Reading y/n from stdin is not a good approach; the commands might
require the XML to be on stdin.
You are right.
So how about let the process give verbose warning message on
dangerous
options and sleep N seconds before proceeding ?
I don't like sleeping tools. That is annoying in scripts, and when
you
really want the system to do something _now_.
I prefer the -f/--force approach, as it's the most common way on
Unix/Linux.
OK. I picked -Z/--do-what-i-say then. :)
-E/-r/-w/-b/-f are considered dangerous now.
Also, exit when non-option ARGV-elements are found, as suggested by
Dejan.
Regards,
Lars
--
Teamlead Kernel, SuSE Labs, Research and Development
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar
Wilde
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
<
cibadmin.patch>_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
