On Mon, Mar 31, 2008 at 11:59:11AM +0900, Simon Horman wrote: > On Fri, Mar 28, 2008 at 08:51:35AM +0100, Andrew Beekhof wrote: > > They look good to me. > > Thanks for repairing the broken assumptions I had about how > > conditionals work with "make dist" ! > > Hi Andrew, Hi All, > > I have applied the Debian patches with the exception of the last one, > "debian: don't enable mgmt or explicitly disable snmp_subagent" as > there is still a little bit of discussion around what to do with > snmp_subagent. > > I have also applied the "make dist" fix "build: Don't distribute > tools/attrd.h as it doesn't exist" as there seems to be little > discussion around it - that is, I don't think anyone objects to it. > > I am holding off on applying the "make dist" build fixes until we > work out what to do with snmp_subagent as it seems related - > the patches are there for anyone who desperately needs them. > > That said, I am happy to push any or all of these patches > and treat what to do with snmp_subagent as a separate issue - > which would put the tree into a state where "make dist" works > while discussions take place. > > I have also applied a couple of other ldirectord and debian patches to > dev that were in my tree[1] as my keys for commit access to the dev > tree have been updated (thanks Sean). > > [1] http://hg.clusterlabs.org/horms/heartbeat/ > * My tree currently contains no changes that aren't in dev and > vice versa, although the exact order of commits differs slightly.
After some discussion with Andrew on IRC I have gone ahead and applied the rest of the changes. This allows "make dist" to work. And as the changes are quite minimalist, they can easily be changed once the discussion about snmp_subagent concludes. -- Horms _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
