Hi Satomi-san, On Wed, Oct 08, 2008 at 02:55:57PM +0900, Satomi TANIGUCHI wrote: > Hi lists, > > I'm posting a STONITH plugin which checks whether the target node is kdumping > or not. > There are some steps to use this, but I believe this plugin is helpful for > failure analysis. > See attached README for details about how to use this. > > There are 2 patches. > The patch named "kdumpcheck.patch" is for Linux-HA-dev(1eae6aaf1af8). > And the patch named "mkdumprd_for_kdumpcheck.patch" is > for mkdumprd version 5.0.39. > > If you're interested in, please give me your comments. > Any comments and suggestions are really appreciated.
The script (kdumpcheck) looks fine to me. Just a few points. The use of upper case variable names: Typically, those denote global (or exported) environment variables. Vars which should live only within a function (though that's not possible with Bourne shell) should be lower case and, probably, have shorter names. Excessive use of upper case strains eyes more than the lower case. That is unless you're a VMS user ;-) Leave "function" and "local" keywords out, unless you want to use /bin/bash for the script, but I don't see why would that be necessary. I wonder if the status function should depend on ping-ing the target node. Document that this works only on Linux. Cheers, Dejan > > Best Regards, > Satomi TANIGUCHI _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
