Hi, On Tue, Nov 10, 2009 at 12:35:29PM +0100, Raoul Bhatia [IPAX] wrote: > hi, > > i've got the patch below waiting in my repository. i remember a > discussion with andrew and/or lars on irc but cannot recall the > exact reasons for doing this in mysqlproxy_monitor(). > > maybe you can figure it out and then either apply or deny my patch ;)
Since the probe is the first action on a resource it does make sense to do the validation there, though I'm not sure why shouldn't it always be done on monitor. The patch is good in principle, but not so in implementation. I'll fix it and apply. Cheers, Dejan > cheers, > raoul > > -------- Original Message -------- > Subject: [PATCH] call validate-all when monitoring with > OCF_RESKEY_CRM_meta_interval=0 > Date: Fri, 18 Sep 2009 16:18:03 +0200 > From: Raoul Bhatia [IPAX] <[email protected]> > To: [email protected] > > # HG changeset patch > # User Raoul Bhatia [IPAX] <[email protected]> > # Date 1253283431 -7200 > # Node ID 751cdef555dee4af414be66de3919a22896c8310 > # Parent be501346e016014a14a3078d4af0e824331586fb > call validate-all when monitoring with OCF_RESKEY_CRM_meta_interval=0 > > diff -r be501346e016 -r 751cdef555de heartbeat/mysql-proxy > --- a/heartbeat/mysql-proxy Wed Sep 16 13:52:48 2009 +0200 > +++ b/heartbeat/mysql-proxy Fri Sep 18 16:17:11 2009 +0200 > @@ -349,6 +349,14 @@ > > mysqlproxy_monitor() > { > + if [ "${OCF_RESKEY_CRM_meta_interval:-0}" -eq "0" ]; then > + # in case of probe, monitor operation is surely treated as > + # under suspension. This will call start operation. > + # (c/p from ocf:heartbeat:sfex) > + mysqlproxy_validate_all > + return $? > + fi > + > if mysqlproxy_status ; then > return $OCF_SUCCESS > fi > _______________________________________________________ > Linux-HA-Dev: [email protected] > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev > Home Page: http://linux-ha.org/ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
