On 2009-11-11 00:16, Lars Marowsky-Bree wrote: > On 2009-11-10T13:57:48, Dejan Muhamedagic <[email protected]> wrote: > >> The patch is good in principle, but not so in implementation. >> I'll fix it and apply. > > The problem is that the mysqld binary might well reside on the shared > device. If you error out with ERR_CONFIGURED in the probe, it will never > get started. > > The patch is buggy. > > validate-all is only allowed to do _syntax_ checks, not _semantic_ ones. > You can only check for all pre-requisites at start time, basically, > because only then all dependencies must be satisfied. > > This is a common mistake, we remove them when we find them, but please > don't add new ones ;-)
Maybe I'm missing something, but I don't follow that. If that is indeed a mistake, then please replace "common" with "ubiquitous" as I believe at least checking for binaries and erroring out if they are not present is something that almost all resource agents do. Examples (by no means exhaustive): - mysql - pgsql - Route - VirtualDomain - Filesystem Some of these check for binaries inside validate, some in a part of the script that is unconditionally executed every time it's invoked (including during validate). So please, either revisit that policy, or fix all those RAs. Cheers, Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
