Hi raoul, > i think it would be better to concat this into one line, something like: > ocf_log err "Failed to read device $DEVICE: $err_output"
I imitated it for handling of Filesystem_monitor_20 and thought about a revision. However, I think that a revision of your patch is better. I think that I had better revise the log output of Filesystem_monitor_20. I attach a patch again. Best Regards, Hideo Yamauchi. --- "Raoul Bhatia [IPAX]" <[email protected]> wrote: > dear On 11/18/2009 04:05 AM, [email protected] wrote: > > patch, but wants you to include it in the latest edition by all means. > > hi, > > in your patch, you add a second output line for the dd error: > > > @@ -754,6 +754,7 @@ > > err_output=`dd if=$DEVICE $dd_opts 2>&1 >/dev/null` > > if [ $? -ne 0 ]; then > > ocf_log err "Failed to read device $DEVICE" > > + ocf_log err "dd said: $err_output" > > return $OCF_ERR_GENERIC > > fi > > return $OCF_SUCCESS > > i think it would be better to concat this into one line, something like: > ocf_log err "Failed to read device $DEVICE: $err_output" > > cheers, > raoul > -- > ____________________________________________________________________ > DI (FH) Raoul Bhatia M.Sc. email. [email protected] > Technischer Leiter > > IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at > Barawitzkagasse 10/2/2/11 email. [email protected] > 1190 Wien tel. +43 1 3670030 > FN 277995t HG Wien fax. +43 1 3670030 15 > ____________________________________________________________________ >
Filesystem.dev.patch
Description: 1810608103-Filesystem.dev.patch
_______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
