Hi,
2011/6/8 Fabio M. Di Nitto <[email protected]>:
>>>> Why is the ldirectord package disabled on RHEL environment?
>>>> I would expect that it would be built as same as (linux-ha)
>>>> resource-agents-1.0.4
>>>> so that we can use the upcoming 3.9.1 as the upgrade version.
>>>
>>> Because ldirectord requires libnet to build and libnet is not available
>>> on default RHEL (unless you explicitly enable EPEL).
>>
>> ldirectord requires no extra packages to build on RHEL. It just a perl
>> script.
>> You may be concerned about the running environment; it requires
>> perl-MailTools
>> at least which can be obtained only from EPEL or CentOS extras, but
>> ldirectord users
>> have been already doing to collect such packages when they want to use it.
>>
>> I can provide a patch to the spec file if it's ok to build.
>>
>> Note that the (linux-ha) resource-agents should have been completely
>> independent
>> from libnet as of 1.0.4. Before that IPv6addr RA was the only
>> dependency of libnet.
> Whops.. yes you are absolutely right. I got confused between the IPAddr
> and ldirectord.
>
> Yes you can either send me a patch, or I can do it. It´s really piece of
> cake.
Ok, I would suggest the attached patch for resolving this particular issue,
but I think there are still some issues left;
1) I'm wondering why this condition is needed; I think we can always use
%{_var}/run/resource-agents in the current version.
----
%if 0%{?fedora} >= 11 || 0%{?centos_version} > 5 || 0%{?rhel} > 5
%dir %{_var}/run/heartbeat/rsctmp
%else
%dir %attr (1755, root, root) %{_var}/run/resource-agents
%endif
----
2) duplicated man8/ldirectord.8.gz is included both in resource-agents
and ldirectord packages. it should not be a big problem though.
----
%{_mandir}/man8/*.8*
(...)
%{_mandir}/man8/ldirectord.8*
----
3) It can not build on RHEL5 with this error. I'd be glad if there is
some kind of backward compatibility.
----
%if 0%{?suse_version} == 0 && 0%{?fedora} == 0 && 0%{?centos_version}
== 0 && 0%{?rhel} == 0
%{error:Unable to determine the distribution/version. This is
generally caused by missing /etc/rpm/macros.dist. Please install the
correct build packages or define the required macros manually.}
----
Regards,
--
Keisuke MORI
diff --git a/resource-agents.spec.in b/resource-agents.spec.in
index 8b39b3f..7dc6670 100644
--- a/resource-agents.spec.in
+++ b/resource-agents.spec.in
@@ -106,7 +106,6 @@ High Availability environment for both Pacemaker and rgmanager
service managers.
%if %{with linuxha}
-%if 0%{?rhel} == 0
%package -n ldirectord
License: GPLv2+
Summary: A Monitoring Daemon for Maintaining High Availability Resources
@@ -136,7 +135,6 @@ lditrecord is simple to install and works with the heartbeat code
See 'ldirectord -h' and linux-ha/doc/ldirectord for more information.
%endif
-%endif
%prep
%if 0%{?suse_version} == 0 && 0%{?fedora} == 0 && 0%{?centos_version} == 0 && 0%{?rhel} == 0
@@ -194,11 +192,6 @@ make install DESTDIR=%{buildroot}
rm -rf %{buildroot}/usr/share/doc/resource-agents
%if %{with linuxha}
-%if 0%{?rhel} != 0
-# ldirectord isn't included on RHEL
-find %{buildroot} -name 'ldirectord.*' -exec rm -f {} \;
-find %{buildroot} -name 'ldirectord' -exec rm -f {} \;
-%endif
%if 0%{?suse_version}
test -d %{buildroot}/sbin || mkdir %{buildroot}/sbin
@@ -270,7 +263,6 @@ rm -rf %{buildroot}
%{_libdir}/heartbeat/findif
%{_libdir}/heartbeat/tickle_tcp
-%if 0%{?rhel} == 0
%if 0%{?suse_version}
%preun -n ldirectord
%stop_on_removal ldirectord
@@ -303,7 +295,6 @@ rm -rf %{buildroot}
/usr/lib/ocf/resource.d/heartbeat/ldirectord
%endif
%endif
-%endif
%changelog
* @date@ Autotools generated version <[email protected]> - @version@-@specver@-@numcomm@.@alphatag@.@dirty@
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
