Hi Raoul,
Hi All,

I removed unnecessary loop handling of data_directory.

This patch is applied to pass after the next patch was applied.
 * http://www.gossamer-threads.com/lists/linuxha/dev/76354


Please please confirm my correction. 
And please commit a correction. 

Best Regards,
Hideo Yamauchi.
diff -r b2a771cba975 heartbeat/postfix
--- a/heartbeat/postfix Tue Nov 15 10:53:38 2011 +0900
+++ b/heartbeat/postfix Tue Nov 15 10:57:10 2011 +0900
@@ -278,16 +278,14 @@
         # check directory permissions
         if ocf_is_true $status_support; then
             user=`postconf $OPTION_CONFIG_DIR -h mail_owner 2>/dev/null`
-            for dir in "$data_dir"; do
-                if ! su -s /bin/sh - $user -c "test -w $dir"; then
-                    if ocf_is_probe; then
-                        ocf_log info "Directory '$dir' is not writable by user 
'$user' during probe."
-                    else
-                        ocf_log err "Directory '$dir' is not writable by user 
'$user'."
-                        return $OCF_ERR_PERM;
-                    fi
+            if ! su -s /bin/sh - $user -c "test -w $data_dir"; then
+                if ocf_is_probe; then
+                    ocf_log info "Directory '$data_dir' is not writable by 
user '$user' during probe."
+                else
+                    ocf_log err "Directory '$data_dir' is not writable by user 
'$user'."
+                    return $OCF_ERR_PERM;
                 fi
-            done
+            fi
         fi
     fi
 
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to