Hi Hideo-san! On 2011-11-15 03:09, [email protected] wrote: > Hi Raoul, > Hi All, > > I removed unnecessary loop handling of data_directory. > > This patch is applied to pass after the next patch was applied. > * http://www.gossamer-threads.com/lists/linuxha/dev/76354 > > > Please please confirm my correction. > And please commit a correction.
the reason i kept this loop is that if we need to check another directory for write permissions in the future we only need to add this directory to the loop. i used to have two loops in the ra: - one for checking if important directories exists and - one for checking if important directories are writable. see https://github.com/raoulbhatia/resource-agents/commit/136dd79 after your status_support patches in mid 2011, the first loop got unfolded. i kept the second loop on purpuse. what are your thoughts? did you simply remove the loop because it is unnecessary or did you have anything else in mind? if it is not too much of a problem, i'd like to keep the write check loop intact just in case we need it for another directory. cheers, raoul -- ____________________________________________________________________ DI (FH) Raoul Bhatia M.Sc. email. [email protected] Technischer Leiter IPAX - Aloy Bhatia Hava OG web. http://www.ipax.at Barawitzkagasse 10/2/2/11 email. [email protected] 1190 Wien tel. +43 1 3670030 FN 277995t HG Wien fax. +43 1 3670030 15 ____________________________________________________________________ _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
