Hi Alan, On Mon, 30 Jul 2007, 15:22:40 +0200, Alan Robertson wrote: > Andrew Beekhof wrote: > > On 7/24/07, Andrew Beekhof <[EMAIL PROTECTED]> wrote: > >> On 7/24/07, Alan Robertson <[EMAIL PROTECTED]> wrote: > >>> The Linux-HA team proudly announces feature and bug-fix release 2.1.1 > >>> of the Linux-HA (aka "Heartbeat", aka "OpenHA") software. > >> Alan, can you please explain the following change-set which you made > >> just before the release: > >> http://hg.linux-ha.org/dev/rev/e46a432e3c50 > >> > >> I am struggling to think of a legitimate reason for most of these > >> messages to be changed from ERRORs to WARNINGs... even assuming they > >> are related to Bug #1657 > >> > >> In particular, I find the following change particularly concerning: > >> if self.rsh(node, self["StartCmd"]) != 0: > >> - self.log ("ERROR: Start command failed on node %s" %(node)) > >> + self.log ("Warn: Start command failed on node %s" %(node)) > > > > Still looking for some sort of response on this... > > > > With one exception, I would be most concerned if these changes were > > required to allow testing to pass. > > Hadn't seen your reply yet. Sorry. I don't have time to read the main > list at the moment. I think I backed those changes out. I don't > understand why expecting a message which always comes out if it succeeds > to be there is a problem - as this is how it originally worked. Each > time a message goes missing, it causes up to a 5 minute delay in the > tests - so it's good to track down if we are still having troubles. > > Are you still having trouble with message loss when using syslog-ng?
I doubt Andrew was refering to trouble with syslog-ng, but rather was afraid of changing the "ERROR" with "Warn" in the logging message, which could, of course, result in several tests suddenly succeed... > It's not something that I see. The comments around most of these seem > to imply that they were to get rid of some problems associated with old > syslog. And, old syslog just isn't suitable for CTS. Again, changing a string shouldn't change where self.log will end up finally... HTH, cheers. l8er manfred _______________________________________________ Linux-HA mailing list [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha See also: http://linux-ha.org/ReportingProblems
