On 7/30/07, Alan Robertson <[EMAIL PROTECTED]> wrote:
> Andrew Beekhof wrote:
> > On 7/24/07, Andrew Beekhof <[EMAIL PROTECTED]> wrote:
> >> On 7/24/07, Alan Robertson <[EMAIL PROTECTED]> wrote:
> >>> The Linux-HA team proudly announces feature and bug-fix release 2.1.1
> >>> of the Linux-HA (aka "Heartbeat", aka "OpenHA") software.
> >> Alan, can you please explain the following change-set which you made
> >> just before the release:
> >> http://hg.linux-ha.org/dev/rev/e46a432e3c50
> >>
> >> I am struggling to think of a legitimate reason for most of these
> >> messages to be changed from ERRORs to WARNINGs... even assuming they
> >> are related to Bug #1657
> >>
> >> In particular, I find the following change particularly concerning:
> >> if self.rsh(node, self["StartCmd"]) != 0:
> >> - self.log ("ERROR: Start command failed on node %s" %(node))
> >> + self.log ("Warn: Start command failed on node %s" %(node))
> >
> > Still looking for some sort of response on this...
> >
> > With one exception, I would be most concerned if these changes were
> > required to allow testing to pass.
>
> Hadn't seen your reply yet. Sorry. I don't have time to read the main
> list at the moment. I think I backed those changes out.
The changes are still present in /dev
> I don't
> understand why expecting a message which always comes out if it succeeds
> to be there is a problem - as this is how it originally worked. Each
> time a message goes missing, it causes up to a 5 minute delay in the
> tests - so it's good to track down if we are still having troubles.
This is not my concern.
My concern, as Manfred correctly pointed out, is that you changed a
number of ERRORs to WARNings which would allow tests to appear to
succeed when in fact they failed.
This was highlighted in the change I quoted:
if self.rsh(node, self["StartCmd"]) != 0:
- self.log ("ERROR: Start command failed on node %s" %(node))
+ self.log ("Warn: Start command failed on node %s" %(node))
StartCmd does not depend on any log messages and if it returns
something other than 0 we most certainly have a big problem.
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
