Hi,

On Wed, Sep 08, 2010 at 09:26:40PM +0200, Jonathan Petersson wrote:
> Hi all,
> 
> I haven't been active on this list for quite some time but I recall
> conntrack-support for heartbeat/pacemaker has been on the wall a few
> times. As I was in the process of installing a couple of new firewalls
> I figured I would spend some time actually getting some support for it
> now that the resource-based system has been put in place (great work
> btw).
> 
> Please notice that the code-set is still work in progress and I'll be
> spending the next few days expanding it.

Any new developments in the meantime?

> The code is available at: http://pastebin.com/Bv060JvR
> 
> Feel free to reply with comments and recommended changes.

Isn't conntrack supposed to be a master-slave implementation,
i.e. where one instance sends updates to other instances? I don't
know if migrate can be used instead of demote/promote.

A note about the style and comments:

Almost everywhere there's stuff such as

    # Check for conntrackd lock-file
        if [ -f $OCF_RESKEY_lck ]; then

There's no need to write a comment which echos what the code says
in the next line.

Cheers,

Dejan

> /Jonathan
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to