On Fri, Feb 25, 2011 at 11:38:50PM +0100, Lars Ellenberg wrote:
> On Fri, Feb 25, 2011 at 06:10:27PM +0100, Dejan Muhamedagic wrote:
> > Hi,
> >
> > On Thu, Feb 24, 2011 at 09:08:45AM -0800, Avestan wrote:
> > >
> > > Hello Dejan,
> > >
> > > Thanks for your information. After looking to the bug filed and solution
> > > by
> > > Dave Blaschke "The link you pointed to..."
> > >
> > > If I understand this correctly, This is really a work around the issue
> > > that
> > > some telnet apps do not
> > > issue "Escape character is '^]'" when logging in while others do.
> >
> > Right. And apparently nobody tested it with the telnet program
> > which prints the message.
>
> There is no reason what so ever to _require_ that telnet message.
Yes, seems logical. Don't know why did Dave insist on matching
that message. Is there anybody who can test this patch?
Thanks,
Dejan
> diff --git a/lib/plugins/stonith/apcmaster.c b/lib/plugins/stonith/apcmaster.c
> --- a/lib/plugins/stonith/apcmaster.c
> +++ b/lib/plugins/stonith/apcmaster.c
> @@ -183,8 +183,6 @@ static int apcmaster_onoff(struct plugin
> static int
> MSLogin(struct pluginDevice * ms)
> {
> - EXPECT(ms->rdfd, EscapeChar, 10);
> -
> /*
> * We should be looking at something like this:
> * User Name :
>
>
> The EXPECT(... login ...), which is the next statement below this,
> will just skip any leading garbage anyways.
>
> > That means you probably won't get any support any more here. And
> > you'll be much better of with Pacemaker.
>
> Absolutely.
>
>
> --
> : Lars Ellenberg
> : LINBIT | Your Way to High Availability
> : DRBD/HA support and consulting http://www.linbit.com
>
> DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems
