Hi Yan,

> That attached patch places it at the end of the loop. I think it should
> work. Please give it a test.

Thank you for the making of the patch.

I confirm movement and report a result.

Best Regards,
Hideo Yamauchi.

--- On Fri, 2011/7/29, Gao,Yan <[email protected]> wrote:

> 
> 
> On 07/29/11 08:29, [email protected] wrote:
> >>>
> >>> I think that the following correction is necessary.
> >>> snmp_subagent/hbagent.c
> >>> (snip)
> >>>                          } else {
> >>>
> >>>                                  /* snmp request */
> >>>                                  snmp_read(&fdset);
> >>>
> >>>                                  ret = handle_heartbeat_msg(); ----> read 
> >>>queueing msg.!!
> >>
> >> I suggest to place this before the select instead.
> >> Or immediately after each call that involves the read_api_msg or
> >> enqueue_msg.
> >>
> >> Probably easier to just place it before the select, or any other call
> >> that may sleep or block for some time.
> > 
> > Thank you for the suggestion of the correction.
> > I want to wait for the opinion of Mr. Yan.
> > 
> >> As hbagent.c was dropped from the heartbeat source tree three years ago,
> >> you will have to carry that patch yourself, I'm affraid.
> >>
> >> Unless someone resurrects the hbagent for current heartbeat,
> >> if still applicable, and possibly improves/integrates it
> >> with the pacemaker side of things.
> > 
> > We do not think about the correction of Heartbeat, too for the moment.
> > We think that only the correction of Pacemaker-mgmt is enough.
> That attached patch places it at the end of the loop. I think it should
> work. Please give it a test.
> 
> Regards,
>   Yan
> -- 
> Gao,Yan <[email protected]>
> Software Engineer
> China Server Team, SUSE.
> 
> -- 
> Gao,Yan <[email protected]>
> Software Engineer
> China Server Team, SUSE.
> 
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to