On 17/09/2025 22:25, Dang Huynh via B4 Relay wrote:
> From: Dang Huynh <dang.hu...@mainlining.org>
> 
> Add documentation describing the RDA Micro modem reset controller
> 
> Signed-off-by: Dang Huynh <dang.hu...@mainlining.org>
> ---
>  .../bindings/power/reset/rda,md-reset.yaml         | 36 
> ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/rda,md-reset.yaml 
> b/Documentation/devicetree/bindings/power/reset/rda,md-reset.yaml
> new file mode 100644
> index 
> 0000000000000000000000000000000000000000..6d09bc8ee6b257aec9d2c4738d285490044003ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/rda,md-reset.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/rda,md-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RDA Micro Modem Reset

What Modem? RDA created only one modem? Still wouldn't it have some
model number?

> +
> +maintainers:
> +  - Dang Huynh <dang.hu...@mainlining.org>
> +
> +description:
> +  The modem has a reset register that can be used to fully reset the board.
> +
> +  To do that, a magic value needs to be written to unprotect the register,
> +  then the soft reset register can be used.
> +
> +properties:
> +  compatible:
> +    const: rda,md-reset

Missing SoC compatible. Every SoC block needs one.


Best regards,
Krzysztof

Reply via email to