On 26/01/2026 09:26, Ard Biesheuvel wrote: > From: Ard Biesheuvel <[email protected]> > > The memblock API guarantees that start is not greater than or equal to > end, so there is no need to test it. And if were, it is doubtful that > breaking out of the loop would be a reasonable course of action here > (rather than attempting to map the remaining regions) > > So let's drop this check.
If start were greater than end, I think it's a pretty safe bet that __map_memblock() would do something horrible. But if memblock makes the guarantee you claim I agree it's preferable to declutter the code: Reviewed-by: Ryan Roberts <[email protected]> > > Signed-off-by: Ard Biesheuvel <[email protected]> > --- > arch/arm64/mm/mmu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index d7faa98f427c..377bdc4d84a1 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1158,8 +1158,6 @@ static void __init map_mem(pgd_t *pgdp) > > /* map all the memory banks */ > for_each_mem_range(i, &start, &end) { > - if (start >= end) > - break; > /* > * The linear map must allow allocation tags reading/writing > * if MTE is present. Otherwise, it has the same attributes as
