On Wed, Jun 05, 2019 at 10:17:12AM -0600, Robert Hancock wrote: > Previously the VIN, IIN and PIN parameters were marked as non-paged, > however on the IRPS5401 these parameters are present on multiple pages. > Add the paged flag for these parameters so they can be detected properly > on such chips. >
Have you tested the impact of this change on other chips where the registers are non-paged ? To reduce risk due to potentially mis-detecting support on other chips, it may be better to add a separate backend driver for this chip. This would also enable support for the MFR_VOUT_PEAK, MFR_IOUT_PEAK, and MFR_TEMPERATURE_PEAK registers which is otherwise unavailable. Thanks, Guenter > Signed-off-by: Robert Hancock <[email protected]> > --- > drivers/hwmon/pmbus/pmbus_core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hwmon/pmbus/pmbus_core.c > b/drivers/hwmon/pmbus/pmbus_core.c > index ef7ee90..6e3aaf1 100644 > --- a/drivers/hwmon/pmbus/pmbus_core.c > +++ b/drivers/hwmon/pmbus/pmbus_core.c > @@ -1395,6 +1395,7 @@ static int pmbus_add_sensor_attrs(struct i2c_client > *client, > .reg = PMBUS_READ_VIN, > .class = PSC_VOLTAGE_IN, > .label = "vin", > + .paged = true, > .func = PMBUS_HAVE_VIN, > .sfunc = PMBUS_HAVE_STATUS_INPUT, > .sbase = PB_STATUS_INPUT_BASE, > @@ -1499,6 +1500,7 @@ static int pmbus_add_sensor_attrs(struct i2c_client > *client, > .reg = PMBUS_READ_IIN, > .class = PSC_CURRENT_IN, > .label = "iin", > + .paged = true, > .func = PMBUS_HAVE_IIN, > .sfunc = PMBUS_HAVE_STATUS_INPUT, > .sbase = PB_STATUS_INPUT_BASE, > @@ -1584,6 +1586,7 @@ static int pmbus_add_sensor_attrs(struct i2c_client > *client, > .reg = PMBUS_READ_PIN, > .class = PSC_POWER, > .label = "pin", > + .paged = true, > .func = PMBUS_HAVE_PIN, > .sfunc = PMBUS_HAVE_STATUS_INPUT, > .sbase = PB_STATUS_INPUT_BASE, > -- > 1.8.3.1 >
