On Fri, 2005-08-05 at 11:00 -0600, Alex Williamson wrote:
> On Fri, 2005-08-05 at 10:12 -0400, Jes Sorensen wrote:
> > +           if (md->type == EFI_BOOT_SERVICES_DATA &&
> > +               md->attribute == EFI_MEMORY_UC) {
> 
>    That seems to have very limited usefulness.  Wouldn't you want
> something like:
> 
> if (md->attribute == EFI_MEMORY_UC && is_available_memory(md))

   Well, except for the WB test in is_available_memory().  The point is
why not include all those types is_available_memory includes?

        Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to