>>>>> "Tony" == Luck, Tony <[EMAIL PROTECTED]> writes:
>> + if (md->type == EFI_BOOT_SERVICES_DATA && + md->attribute ==
>> EFI_MEMORY_UC) {
Tony> That will certainly stop this code from crashing on Tiger.
Tony> But it still doesn't really do what the comment claims it will
Tony> do. The "attribute" field is a bitmask ... most of the memory
Tony> that was dropped because of holes or incompatible attributes
Tony> within the same granule will also have other allowable
Tony> attributes. So final version of this should be checking
Tony> "md->attribute & EFI_MEMORY_UC" rather than "==".
Ok,
I don't have all the EFI specs at hand, didn't realize it was a
bitmask. We should probably combine that with something like what Alex
Williamson was suggesting.
Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
