Bartlomiej Zolnierkiewicz wrote:

ACK everything else (that I snipped)...

@@ -303,6 +281,7 @@ static void qd6580_set_pio_mode(ide_driv
static int __init qd_testreg(int port)
 {
+       static DEFINE_SPINLOCK(qd65xx_lock);
        unsigned long flags;
        u8 savereg, readreg;

At this point, the lock is largely pointless, isn't it?

Seems like you might as well use local_irq_save/restore.

        Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to