Jeff Garzik wrote:
Mark Lord wrote:
sata_mv No soft resets.
Soft resets rarely have significant effect with these chips,
so always do a hard reset instead.
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
--- old/drivers/ata/sata_mv.c 2008-01-24 14:49:28.000000000 -0500
+++ new/drivers/ata/sata_mv.c 2008-01-24 14:51:53.000000000 -0500
@@ -2414,8 +2414,7 @@
static void mv_error_handler(struct ata_port *ap)
{
- ata_do_eh(ap, mv_prereset, ata_std_softreset,
- mv_hardreset, mv_postreset);
+ ata_do_eh(ap, mv_prereset, NULL, mv_hardreset, mv_postreset);
}
Can you give a bit more explanation?
..
When I hit the existing EH, the system locks up.
When I remove the ata_std_softreset from that line,
it no longer locks up.
It still does have other issues, though, so you could drop
that patch for now, and I'll reissue it when I get round to
fixing that particularly horribly broken part of the driver later.
Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
