On Thu, Feb 13, 2014 at 02:40:23PM +0800, Barry Song wrote: > From: Xianglong Du <[email protected]> > > In resume entry, use dev_get_drvdata() instead of to_platform_device(dev) + > platform_get_drvdata(pdev). > > Signed-off-by: Xianglong Du <[email protected]> > Signed-off-by: Barry Song <[email protected]> > --- > drivers/input/misc/sirfsoc-onkey.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/misc/sirfsoc-onkey.c > b/drivers/input/misc/sirfsoc-onkey.c > index 097c10a..8e45bf11 100644 > --- a/drivers/input/misc/sirfsoc-onkey.c > +++ b/drivers/input/misc/sirfsoc-onkey.c > @@ -157,8 +157,7 @@ static int sirfsoc_pwrc_remove(struct platform_device > *pdev) > #ifdef CONFIG_PM_SLEEP > static int sirfsoc_pwrc_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct sirfsoc_pwrc_drvdata *pwrcdrv = platform_get_drvdata(pdev); > + struct sirfsoc_pwrc_drvdata *pwrcdrv = dev_get_drvdata(dev);
I believe we should use accessors matching the object type. Currently dev_get_drvdata and platform_get_drvdata return the same object, but they do not have to. IOW I prefer the original code. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
