On Mon, 2024-07-01 at 15:27 +0000, Jarkko Sakkinen wrote: > On Mon, 2024-07-01 at 17:14 +0200, Francesco Dolcini wrote: > > On Mon, Jul 01, 2024 at 03:02:11PM +0000, Jarkko Sakkinen wrote: > > > On Fri, 2024-06-21 at 10:50 +0100, Vitor Soares wrote: > > > > From: Vitor Soares <[email protected]> > > > > > > > > "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not > > > > allowing module autoloading and leading to the following message: > > > > > > > > "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p" > > > > > > > > Based on: > > > > commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID") > > > > > > > > Fix this by adding the corresponding "attpm20p" spi_device_id entry. > > > > > > > > Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string > > > > atmel,attpm20p") > > > > Cc: [email protected] > > > > Signed-off-by: Vitor Soares <[email protected]> > > > > > > This is not a bug fix. This is a feature. > > > > I believe that some maintainer have a different view on this kind of > > patches compared to you, adding new device id would be material for > > stable, or this specific issue preventing module auto loading. > > > > I noticed that this specific view is not new from you, see > > https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/. > > > > With that said, I am ok with it. > > > > Do you want a new patch version without Fixes/Cc:stable tags or you can > > remove those while applying? > > > > Francesco > > Hmm... OK, I'll apply this version, I see your point here! > > Reviewed-by: Jarkko Sakkinen <[email protected]>
Should be soon available in -next. BR, Jarkko
